<div dir="ltr"><div bgcolor="#232729" text="#eeeeec" link="#4a90d9" vlink="#eeeeec"><div style="width:71ch">On Mon, 2017-12-11 at 12:02 +1100, Alistair Popple wrote:</div><blockquote type="cite"><blockquote type="cite"><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>Nak. The dtb is built from the dts, so the rule should be  dtb: dts.</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>There's an additional dependency on the dtsi, so we make sure that is</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>listed too.</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>Think of it like a C file:</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>foo.o: foo.c foo.h</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>Please take this patch instead:</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span> <a href="https://lists.ozlabs.org/pipermail/pdbg/2017-December/000000.html" target="_blank">https://lists.ozlabs.org/<wbr>pipermail/pdbg/2017-December/<wbr>000000.html</a></pre></blockquote><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>dtc supports the `-d` option:</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>  -d, --out-dependency <arg> </pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>        Output dependency file</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>If we were going to do this properly we'd just teach make how to generate the</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>dependencies automatically. In the meantime I agree - removing the dependencies</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>doesn't seem right. Cyril does Joel's patch above fix the issue you were seeing?</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre></blockquote><div style="width:71ch"><br></div><div style="width:71ch">Yeah should fix the build issue.</div><div style="width:71ch"><br></div><div style="width:71ch">Can we add .INTERMEDIATE to Joels patch? Otherwise I'm pretty sure its going to leave the .dtb files sitting around... If we do want that we should mark the %.dtb rule as precious and also add to .gitignore... either way, just... consistency :)</div><div style="width:71ch"><br></div><div style="width:71ch">Cy<span id="m_-3279510889438256852-x-evo-selection-start-marker"></span><span id="m_-3279510889438256852-x-evo-selection-end-marker"></span>ril</div><div style="width:71ch"><br></div><blockquote type="cite"><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>Regards,</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>Alistair</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre><blockquote type="cite"><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>Cheers,</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>Joel</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre><blockquote type="cite"><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span> %.dtb: %.dts</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>        $(DTC_V)dtc -q -i$(dir $@) -I dts $< -O dtb > $@</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>--</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>2.15.1</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>--</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span>Pdbg mailing list</pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><a href="mailto:Pdbg@lists.ozlabs.org" target="_blank">Pdbg@lists.ozlabs.org</a></pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><a href="https://lists.ozlabs.org/listinfo/pdbg" target="_blank">https://lists.ozlabs.org/<wbr>listinfo/pdbg</a></pre></blockquote></blockquote><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre><pre><span class="m_-3279510889438256852-x-evo-quoted"><span class="m_-3279510889438256852-x-evo-quote-character">> </span></span><br></pre></blockquote><div class="m_-3279510889438256852-x-evo-signature-wrapper"><span class="m_-3279510889438256852-x-evo-signature" id="m_-3279510889438256852none"></span></div></div></div>