[PATCH v2 21/30] patman: Require tags to be before sign-off

Jonathan Nieder jrnieder at gmail.com
Tue Oct 27 17:05:32 AEDT 2020

Simon Glass wrote:
> On Sun, 25 Oct 2020 at 19:23, Sean Anderson <seanga2 at gmail.com> wrote:

>> I also like to put SOBs on top because it groups all the commit-specific
>> information before any patman-specific tags. The last commit (the HEAD)
>> usually has several tags (Series-to/cc, Series-process-log,
>> Cover-letter, etc.) which are unrelated to the commit itself.
>> The tool should do what is best for us humans, not what is convenient
>> for the tool.
> I suppose it can be done. But we have the same problem with Change-Id.
> Do you use gerit?

I assume this is mostly about Commit-Notes, when used without
following the rfc-style format that has subsequent lines indented.

If so, then this issue isn't specific to Gerrit: it applies when using
Git directly (the "git interpret-trailers" command, "git commit
--amend --signoff", and so on).

As long as you're following rfc822 syntax, all is fine, so in some
sense the issue here is the Commit-Notes tag.  Should it go in the
commit message body instead of the trailer paragraph?


More information about the Patchwork mailing list