[RFC PATCH v2 0/1] add parserelations management command

[Daniel Axtens]

Rohit Sarkar <rohitsarkar5398 at gmail.com> writes:

> Hey,
> On Fri, Jun 12, 2020 at 12:04:54AM +0530, Rohit Sarkar wrote:
>> The parserelations command will be used to bulk import patch relations into
>> Patchwork using a "patch groups" file.
>> The patch groups file is structured such that each line contains a
>> relation.
>> Eg patch groups file contents.
>> 1 3 4
>> 2
>> 5 9 10
>> 
>> In this case 2 relations will be ingested into Patchwork, (1,3,4) and
>> (5,9,10). Further group (5,9,10) also points to two upstream commit
>> references.
>> Note that before ingesting the relations the existing relations in the
>> DB are removed.
>> 
>> v1..v2
>> - remove commit references from the patch groups file.
>> - Update documentation
>> - rename some variables to remove the overloading.
>> - use filter and update instead of get and save to reduce the db calls.
>>   (Visible performance enhancement)
>> 
>> Leaving the copyright untouched till Ralf and Lukas comment on how to
>> proceed.
>> 
>> Rohit Sarkar (1):
>>   management: introduce parserelations command
>> 
>>  docs/deployment/management.rst                | 26 +++++++
>>  .../management/commands/parserelations.py     | 71 +++++++++++++++++++
>>  patchwork/tests/test_management.py            |  7 ++
>>  3 files changed, 104 insertions(+)
>>  create mode 100644 patchwork/management/commands/parserelations.py
>> 
>> -- 
>> 2.23.0.385.gbc12974a89
>> 
>
> Just wanted to follow up on this. Does this look good?

I was thinking about this as I washed the dishes last night.

Purging all relations in the database means that if any API-based user
of relations emerges before the big public servers adopt a release with
this, then they'll never be able to use it.

What's the speed impact of doing two passes through the data, with pass
1 collecting all the projects that this touches and pass 2 actually
installing the relations?

Regards,
Daniel

> Thanks,
> Rohit