[PATCH v2] docker: update dependency for current build

[Daniel Axtens]

Lukas Bulwahn <lukas.bulwahn at gmail.com> writes:

> From: Pranav Annam <pranavannam at gmail.com>
>
> The dependency libssl1.0-dev in the Dockerfile makes docker build fail:
>
>   The following packages have unmet dependencies:
>    libmysqlclient-dev : Depends: libssl-dev (>= 1.1.1-1ubuntu2.1~18.04.5~)
>   but it is not going to be installed
>   E: Unable to correct problems, you have held broken packages.
>
> There seems to be a conflict with different versions of libssl and
> libmysqlclient that did not exist previously with Ubuntu 18.04.

Huh, I rebuilt my image a few weeks ago and didn't see this.

So I tried this:

docker-compose down
docker rmi patchwork_web:latest
docker-compose build --no-cache web

Then I was able to reproduce the problem. I think it was being masked by
the cache on my end, but I can't find a change that would have
introduced it. Commit a0db4732139d ("docker: Use pyenv for Python
versions") looks like it introduced the dependency, but clearly it
worked then, and we haven't changed the base image or the other packages
we install! It is weird that it would have broken under us like this. 

Anyway, your patch seems correct to me, and fixes the issue. Applied.

Thank you for your contribution to Patchwork!

Regards,
Daniel

>
> Just use the current libssl-dev from Ubuntu 18.04 to fix the build.
>
> Signed-off-by: Pranav Annam <pranavannam at gmail.com>
> [rephrased commit message]
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn at gmail.com>
> ---
>
> Pranav, here is my proposal on how future patches should look
> like. Please look at the difference to your original patch.
>
> Stephen, Daniel, please pick the patch with the commit message
> that you prefer and explain to us why (for future newcomers to
> be pointed out to and learn).
>
>  tools/docker/Dockerfile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
> index 5ef1120..62ac461 100644
> --- a/tools/docker/Dockerfile
> +++ b/tools/docker/Dockerfile
> @@ -35,7 +35,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
>      libpq-dev \
>      libreadline-dev \
>      libsqlite3-dev \
> -    libssl1.0-dev \
> +    libssl-dev \
>      mysql-client \
>      postgresql-client \
>      tzdata \
> -- 
> 2.17.1
>
> _______________________________________________
> Patchwork mailing list
> Patchwork at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork