Lost pull requests...

David Miller davem at davemloft.net
Thu Jan 18 06:26:54 AEDT 2018


From: Stephen Finucane <stephen at that.guru>
Date: Wed, 17 Jan 2018 19:09:29 +0000

> On Mon, 2018-01-15 at 13:25 -0500, David Miller wrote:
>> I've noticed for a while now that various pull requests are not
>> being recognized by patchwork.ozlabs.org and therefore don't
>> end up in the patchwork queue.
>> 
>> Even ones I send myself are having this problem.  All I am doing
>> is putting the contents of "git request-pull ..." into an email
>> and adding some other informative text to the beginning.
>> 
>> I attach two examples of pull requests that patchwork at ozlabs
>> didn't queue up.
>> 
>> Thanks!
> 
> Here's our issue:
> 
>   https://github.com/git/git/commit/e66d7c37a5f
> 
> The regex we used to detect these mails was case sensitive. I can
> submit a patch to simply make this case insensitive, which should
> resolve this issue. However, I also noticed that the file, as
> downloaded by my email client (Evolution), has CRLF line endings.
> 
>    $ file ~/Downloads/net_pull.txt 
>   /home/sfinucan/Downloads/net_pull.txt: ASCII text, with CRLF, CR line terminators
> 
> I can't see how this would happen with 'git-request-pull', so can I
> safely assume it's my email client messing up here?

Here is the attachment again, sent as Application/Octet-Stream instead
of Text/Plain, see if it makes a difference:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: net_pull.txt
Type: application/octet-stream
Size: 6547 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/patchwork/attachments/20180117/4bd3df66/attachment-0001.obj>


More information about the Patchwork mailing list