Lost pull requests...

Stephen Finucane stephen at that.guru
Thu Jan 18 06:09:29 AEDT 2018

On Mon, 2018-01-15 at 13:25 -0500, David Miller wrote:
> I've noticed for a while now that various pull requests are not
> being recognized by patchwork.ozlabs.org and therefore don't
> end up in the patchwork queue.
> Even ones I send myself are having this problem.  All I am doing
> is putting the contents of "git request-pull ..." into an email
> and adding some other informative text to the beginning.
> I attach two examples of pull requests that patchwork at ozlabs
> didn't queue up.
> Thanks!

Here's our issue:


The regex we used to detect these mails was case sensitive. I can
submit a patch to simply make this case insensitive, which should
resolve this issue. However, I also noticed that the file, as
downloaded by my email client (Evolution), has CRLF line endings.

   $ file ~/Downloads/net_pull.txt 
  /home/sfinucan/Downloads/net_pull.txt: ASCII text, with CRLF, CR line terminators

I can't see how this would happen with 'git-request-pull', so can I
safely assume it's my email client messing up here?


More information about the Patchwork mailing list