[PATCH 3/6] docker: Remove bash aliases
dja at axtens.net
Sat Apr 28 01:24:24 AEST 2018
I use createsu but not runserver, and I guess I could learn to just
FWIW I don't think Wednesday to Friday is really long enough on the list
to merge patches that drop stuff.
Anyway I will now return to the remainder of my holidays.
Stephen Finucane <stephen at that.guru> writes:
> These seem to be a hangover from the Vagrant days. I don't personally
> use them anymore and I'm not sure anyone else does. I think they can go.
> Signed-off-by: Stephen Finucane <stephen at that.guru>
> Cc: Daniel Axtens <dja at axtens.net>
> tools/docker/Dockerfile | 8 --------
> tools/docker/bashrc | 5 -----
> 2 files changed, 13 deletions(-)
> delete mode 100644 tools/docker/bashrc
> diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
> index 68a62e15..109410bb 100644
> --- a/tools/docker/Dockerfile
> +++ b/tools/docker/Dockerfile
> @@ -43,15 +43,7 @@ RUN pip2 install virtualenv tox && \
> # we deliberately leave the requirements files in tmp so we can
> # ping the user in entrypoint.sh if the change them!
> -COPY tools/docker/bashrc /tmp/bashrc
> -# we put the code in ~/patchwork rather than ~ so that we
> -# can put in these bashrc snippets without dirtying the
> -# working directory
> -RUN cat /tmp/bashrc >> /home/patchwork/.bashrc
> COPY tools/docker/entrypoint.sh /usr/local/bin/entrypoint.sh
> ENTRYPOINT ["/usr/local/bin/entrypoint.sh"]
> USER patchwork
> WORKDIR /home/patchwork/patchwork
> diff --git a/tools/docker/bashrc b/tools/docker/bashrc
> deleted file mode 100644
> index eb2ed7dd..00000000
> --- a/tools/docker/bashrc
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -# This snippet is appended to ~/.bashrc when the container is created
> -alias runserver='python3 $PROJECT_HOME/manage.py runserver 0.0.0.0:8000'
> -alias createsu='python3 $PROJECT_HOME/manage.py createsuperuser'
More information about the Patchwork