[PATCH] Include all email headers in mboxes

Johannes Berg johannes at sipsolutions.net
Thu Apr 5 21:00:10 AEST 2018

On Thu, 2018-04-05 at 19:58 +1000, Daniel Axtens wrote:
> vkabatov at redhat.com writes:
> > From: Veronika Kabatova <vkabatov at redhat.com>
> > 
> > Solves issue #165 (Exported mboxes should include In-Reply-To,
> > References, etc headers). Instead of including only a few chosen ones,
> > all received headers are added to mboxes.
> Thanks for the patch.
> I'm a little worried that this will get really messy - I've included a
> snippet of headers from an email from an unrelated bug below. Maybe we
> don't care - I guess this isn't really for human consumption but is for
> consumption by e.g. git-am.
> Alternatively we can blacklist headers: I don't think there's anything
> worth having in Received, X-*, List-*, DKIM, ARC, SPF, etc. But I wonder
> if this is just whack-a-mole in reverse.
> Thoughts?

I'm not really sure human consumption would be a worry for mbox files?
Having the full headers - since it's sort of an email archive already -
would be useful though.

In particular, the change to keep the original Subject would be useful
for us, as we have a script that automatically replies to the email
saying "thank you, I've applied your patch" or similar.

That said, using a dict for this is in general not quite right, since
many header lines are valid multiple times, e.g. "Received:", but I'm
not sure they're even all stored.


More information about the Patchwork mailing list