[PATCH] fixtures: Add a bunch of useful default tags

Florian Fainelli f.fainelli at gmail.com
Tue Jan 24 05:20:19 AEDT 2017


On 01/22/2017 01:25 PM, Stephen Finucane wrote:
> On Wed, 2017-01-18 at 17:36 -0800, Florian Fainelli wrote:
>> A lot of project these days have adopted the Linux tags for their
>> commit
>> messages. Augment the default fixtures with a bunch of commonly found
>> tags: Reviewed-by, Reported-by, Suggested-by, Signed-off-by, Tested-
>> by,
>> and finally Fixes which is increasingly popular (at least for Linux)
>>
>> Signed-off-by: Florian Fainelli <f.fainelli at gmail.com>
> 
> I'm a little nervous to apply this, owing to the large number of
> additional tag columns that would be displayed in the UI (many of which
> won't be used for all projects). It is possible to modify these on a
> per-instance basis and regenerate the tags - just ask your instance
> administrator. Perhaps this would be a better approach than making it
> the default for all instances?

Maybe this goes back to Rafal's comment, there seems to be value in the
parser to recognize tags people could be responding with, and amending
them to the patch, but we would not really care about having these
additional tags displayed, along with their patch count in the patch
list view.

Would it be more acceptable if the view and parsing were a little more
independent here?

Thanks!
-- 
Florian


More information about the Patchwork mailing list