[PATCH] fixtures: Add a bunch of useful default tags

Stephen Finucane stephen at that.guru
Mon Jan 23 08:25:16 AEDT 2017


On Wed, 2017-01-18 at 17:36 -0800, Florian Fainelli wrote:
> A lot of project these days have adopted the Linux tags for their
> commit
> messages. Augment the default fixtures with a bunch of commonly found
> tags: Reviewed-by, Reported-by, Suggested-by, Signed-off-by, Tested-
> by,
> and finally Fixes which is increasingly popular (at least for Linux)
> 
> Signed-off-by: Florian Fainelli <f.fainelli at gmail.com>

I'm a little nervous to apply this, owing to the large number of
additional tag columns that would be displayed in the UI (many of which
won't be used for all projects). It is possible to modify these on a
per-instance basis and regenerate the tags - just ask your instance
administrator. Perhaps this would be a better approach than making it
the default for all instances?

Thoughts?

Stephen 

> ---
>  patchwork/fixtures/default_tags.xml | 32
> +++++++++++++++++++++++++++++++-
>  1 file changed, 31 insertions(+), 1 deletion(-)
> 
> diff --git a/patchwork/fixtures/default_tags.xml
> b/patchwork/fixtures/default_tags.xml
> index ca5ccfd5a217..7920ce11b9b2 100644
> --- a/patchwork/fixtures/default_tags.xml
> +++ b/patchwork/fixtures/default_tags.xml
> @@ -15,4 +15,34 @@
>      <field type="CharField" name="pattern">^Tested-by:</field>
>      <field type="CharField" name="abbrev">T</field>
>    </object>
> -</django-objects>
> \ No newline at end of file
> +  <object pk="4" model="patchwork.tag">
> +    <field type="CharField" name="name">Reviewed-by</field>
> +    <field type="CharField" name="pattern">^Reviewed-by:</field>
> +    <field type="CharField" name="abbrev">R</field>
> +  </object>
> +  <object pk="5" model="patchwork.tag">
> +    <field type="CharField" name="name">Reported-by</field>
> +    <field type="CharField" name="pattern">^Reported-by:</field>
> +    <field type="CharField" name="abbrev">RE</field>
> +  </object>
> +  <object pk="6" model="patchwork.tag">
> +    <field type="CharField" name="name">Suggested-by</field>
> +    <field type="CharField" name="pattern">^Suggested-by:</field>
> +    <field type="CharField" name="abbrev">SU</field>
> +  </object>
> +  <object pk="7" model="patchwork.tag">
> +    <field type="CharField" name="name">Signed-off-by</field>
> +    <field type="CharField" name="pattern">^Signed-off-by:</field>
> +    <field type="CharField" name="abbrev">S</field>
> +  </object>
> +  <object pk="8" model="patchwork.tag">
> +    <field type="CharField" name="name">Tested-by</field>
> +    <field type="CharField" name="pattern">^Tested-by:</field>
> +    <field type="CharField" name="abbrev">T</field>
> +  </object>
> +  <object pk="9" model="patchwork.tag">
> +    <field type="CharField" name="name">Fixes</field>
> +    <field type="CharField" name="pattern">^Fixes:</field>
> +    <field type="CharField" name="abbrev">F</field>
> +  </object>
> +</django-objects>



More information about the Patchwork mailing list