[PATCH] bin/pwclient: fix spurious except catch

Stephen Finucane stephenfinucane at hotmail.com
Mon Sep 26 01:17:18 AEST 2016


On 25 Sep 12:48, Yann E. MORIN wrote:
> The 'with' statement does not start an exception block like 'try' would,
> so we get an error executing pwclient:
> 
>       File "/home/ymorin/bin/pwclient", line 300
>         except IOError:
>              ^
>     SyntaxError: invalid syntax
> 
> Instead, don't try to catch any exception: any failure will be
> propagated back up the stack and eventually cause an abort, which is
> anyway what the except clause was trying to do.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Stephen Finucane <stephenfinucane at hotmail.com>

How did I miss this :/

Reviewed-by: Stephen Finucane <stephenfinucane at hotmail.com>

...and merged.


More information about the Patchwork mailing list