[PATCH] bin/pwclient: fix spurious except catch

Yann E. MORIN yann.morin.1998 at free.fr
Sun Sep 25 20:48:32 AEST 2016

The 'with' statement does not start an exception block like 'try' would,
so we get an error executing pwclient:

      File "/home/ymorin/bin/pwclient", line 300
        except IOError:
    SyntaxError: invalid syntax

Instead, don't try to catch any exception: any failure will be
propagated back up the stack and eventually cause an abort, which is
anyway what the except clause was trying to do.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
Cc: Stephen Finucane <stephenfinucane at hotmail.com>
 patchwork/bin/pwclient | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/patchwork/bin/pwclient b/patchwork/bin/pwclient
index b63db53..ce18e54 100755
--- a/patchwork/bin/pwclient
+++ b/patchwork/bin/pwclient
@@ -297,9 +297,6 @@ def action_get(rpc, patch_id):
     with open(fname, 'w') as f:
         print('Saved patch to %s' % fname)
-    except IOError:
-        sys.stderr.write("Failed to write to %s\n" % fname)
-        sys.exit(1)
 def action_apply(rpc, patch_id, apply_cmd=None):

More information about the Patchwork mailing list