[PATCH v2 4/4] models: Remove TODO from 'refresh_tag_counts'

[Daniel Axtens]

LGTM.

Reviewed-by: Daniel Axtens <dja at axtens.net>

Regards,
Daniel

Stephen Finucane <stephen at that.guru> writes:

> There's actually no harm keeping this around as it makes the code.
> Remove the TODO, replacing it with a note on why the function exists.
>
> Signed-off-by: Stephen Finucane <stephen at that.guru>
> ---
>  patchwork/models.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/patchwork/models.py b/patchwork/models.py
> index f6a2f26..b18213d 100644
> --- a/patchwork/models.py
> +++ b/patchwork/models.py
> @@ -296,7 +296,8 @@ class Submission(EmailMixin, models.Model):
>      # patchwork metadata
>  
>      def refresh_tag_counts(self):
> -        pass  # TODO(sfinucan) Once this is only called for patches, remove
> +        # This is subclassed on 'Patch' to do something useful
> +        pass
>  
>      def is_editable(self, user):
>          return False
> -- 
> 2.7.4
>
> _______________________________________________
> Patchwork mailing list
> Patchwork at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/patchwork/attachments/20161021/a282b67a/attachment.sig>