[PATCH v2 4/4] models: Remove TODO from 'refresh_tag_counts'

Stephen Finucane stephen at that.guru
Thu Oct 20 18:28:56 AEDT 2016


There's actually no harm keeping this around as it makes the code.
Remove the TODO, replacing it with a note on why the function exists.

Signed-off-by: Stephen Finucane <stephen at that.guru>
---
 patchwork/models.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/patchwork/models.py b/patchwork/models.py
index f6a2f26..b18213d 100644
--- a/patchwork/models.py
+++ b/patchwork/models.py
@@ -296,7 +296,8 @@ class Submission(EmailMixin, models.Model):
     # patchwork metadata
 
     def refresh_tag_counts(self):
-        pass  # TODO(sfinucan) Once this is only called for patches, remove
+        # This is subclassed on 'Patch' to do something useful
+        pass
 
     def is_editable(self, user):
         return False
-- 
2.7.4



More information about the Patchwork mailing list