[PATCH 06/10] parser: Use full regexps for delegation rules paths

Finucane, Stephen stephen.finucane at intel.com
Fri Jan 8 21:27:36 AEDT 2016

On 06 Jan 21:53, Johannes Berg wrote:
> On Wed, 2016-01-06 at 17:17 +0000, Finucane, Stephen wrote:
>> > Actually, this patch adds regex support in place of the fnmatch
> > already used. In light of the security risks, I'm reluctant to add
> > support for this in its current form. Far as I see it, we can either
> > avoid regex support or if it's valuable enough to include, make it an
> > optional feature that can be enabled/disabled accordingly. I'd rather
> > the former for simplicity, though I don't have any visibility into
> > how useful this is so I'd like input. Thoughts?
> Personally, I see very little use for regex matches over fnmatch. I'd
> expect that, as far as we'd use it for wireless, to really only have
> patterns like
>    my/path/*
>    your/path/*
> johannes

I agree. I'm happy to drop this patch for now and reassess it as
necessary in the future.


More information about the Patchwork mailing list