[PATCH v3 2/5] parser: Trivial rename of functions
stephen at that.guru
Fri Dec 2 21:14:51 AEDT 2016
On Fri, 2016-12-02 at 13:49 +1100, Daniel Axtens wrote:
> > - delegate = find_delegate(mail)
> > + delegate = find_delegate_by_header(mail)
> > if not delegate and diff:
> > filenames = find_filenames(diff)
> > - delegate = auto_delegate(project, filenames)
> > + delegate = find_delegate_by_filename(project,
> > filenames)
> It's not 100% clear from the context: are we using multiple
> or just one filename? Your argument and function name don't match up.
Good call - it's multiple filenames. I've applied this as is to fix
Tom's issue, but I'll address this in a follow-up patch.
> Apart from that it looks good to me.
More information about the Patchwork