[PATCH v3 2/5] parser: Trivial rename of functions
Daniel Axtens
dja at axtens.net
Fri Dec 2 13:49:11 AEDT 2016
> - delegate = find_delegate(mail)
> + delegate = find_delegate_by_header(mail)
> if not delegate and diff:
> filenames = find_filenames(diff)
> - delegate = auto_delegate(project, filenames)
> + delegate = find_delegate_by_filename(project, filenames)
It's not 100% clear from the context: are we using multiple filenames,
or just one filename? Your argument and function name don't match up.
Apart from that it looks good to me.
Regards,
Daniel
>
> series = find_series(mail)
> # We will create a new series if:
> --
> 2.9.3
>
> _______________________________________________
> Patchwork mailing list
> Patchwork at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork
More information about the Patchwork
mailing list