[PATCH 3/6] tests: Don't change settings.STATIC_URL in the XML-RPC tests

Finucane, Stephen stephen.finucane at intel.com
Wed Sep 23 03:24:57 AEST 2015


> I tracked down a weird bug where the Selenium tests supposed to serve
> all static files (.css, .js. ...) weren't doing so when running the
> full test suite, but everything was working when running the tests in
> isolation.
> 
> Turns out one of the other tests was changing settings.STATIC_URL
> mid-way without restoring the original value in tearDown() and thus
> impacting other tests.
> 
> It seems that this change wasn't necessary, the XML-RPC server doesn't
> server any static file anyway.
> 
> Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>

I think I've also seen this bug (it causes failures with Django 1.6). Glad you identified the issue.

Acked-by: Stephen Finucane <stephen.finucane at intel.com>


More information about the Patchwork mailing list