[PATCH 3/6] tests: Don't change settings.STATIC_URL in the XML-RPC tests

Damien Lespiau damien.lespiau at intel.com
Wed Sep 23 02:11:46 AEST 2015


I tracked down a weird bug where the Selenium tests supposed to serve
all static files (.css, .js. ...) weren't doing so when running the
full test suite, but everything was working when running the tests in
isolation.

Turns out one of the other tests was changing settings.STATIC_URL
mid-way without restoring the original value in tearDown() and thus
impacting other tests.

It seems that this change wasn't necessary, the XML-RPC server doesn't
server any static file anyway.

Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
---
 patchwork/tests/test_xmlrpc.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/patchwork/tests/test_xmlrpc.py b/patchwork/tests/test_xmlrpc.py
index b7c629e..1aef03c 100644
--- a/patchwork/tests/test_xmlrpc.py
+++ b/patchwork/tests/test_xmlrpc.py
@@ -31,7 +31,6 @@ class XMLRPCTest(LiveServerTestCase):
     fixtures = ['default_states']
 
     def setUp(self):
-        settings.STATIC_URL = '/'
         self.url = (self.live_server_url +
                     reverse('patchwork.views.xmlrpc.xmlrpc'))
         self.rpc = xmlrpclib.Server(self.url)
-- 
2.1.0



More information about the Patchwork mailing list