[PATCH 25/46] filters: Rewrite the submitter autocompletion code

Damien Lespiau damien.lespiau at intel.com
Tue Aug 25 00:17:44 AEST 2015

On Mon, Nov 10, 2014 at 09:01:33PM +0800, Jeremy Kerr wrote:
> Hi Damien,
> >We now have a nice(r) autocompletion widget that will popup the list of
> >options directly underneath the input fild.
> woot!
> >A slight change in behaviour is that we now don't allow "free form"
> >submitter search, ie we need a valid completion to search with that
> >specific person (through its primary key). I didn't remove the backend
> >logic that allows the "free form" mechanism, but maybe we should.
> Originally, I've included that for the case where we have no client-side
> javascript, and hence no completion. It looks like that'll still work with
> this change though - is that right?

I just tried patchwork without Javascript and I can't even reach the
filtering form as it needs a bit of javacript to expand the "filters"

I really really don't think patchwork web UI should consider being
usable without javascript in this day and age. For people that do not
want to use the Web with javascript enabled, I'd argue we should make
the other interface(s) (ie pwclient atm) useful enough (which is already
the case?) to replace the web UI instead of crippling the latter.


More information about the Patchwork mailing list