[pull request] Pull request for branch yem/pwclient

Jeremy Kerr jk at ozlabs.org
Tue Jul 1 11:13:58 EST 2014


Hi Yann,

> We can either offer a migration plan, or continue supporting the old
> format.
> 
> Needless to say, supporting the old format would make the code ugly.

I agree, I don't think we want to transparently support the old format,
for exactly that reason.

> As for the migration, there are three possibilities:
>  1) migrate transparently on first call;
>  2) error-out on old format, instructing to run with the --migrate
>     option;
>  3) error-out on old format, instruct to run another program to do the
>     migration.
> 
> But the migration might not be that easy: some people (like me) may have
> commented sections in their current .pwclientrc, so it is easier to
> switch projects.
> 
> So, that's why I just decided to error-out on the old format, rather
> than either migrate or support the legacy format.
> 
> Of course, the new .pwclientrc downloaded from the project's page should
> be changed to include instructions on how to migrate, if needed.

If it's feasible to upgrade the .pwclientrc (while saving a backup),
then that would be nice. Otherwise, let's error out, and print a URL to
a little guide (under /help/) to manually migrate.

Cheers,


Jeremy


More information about the Patchwork mailing list