[pull request] Pull request for branch yem/pwclient

Yann E. MORIN yann.morin.1998 at free.fr
Tue Jul 1 02:02:24 EST 2014


Jeremy, All,

On 2014-06-30 10:56 +0800, Jeremy Kerr spake thusly:
> > As I previosuly explained [0], it is not really convenient to use pwclient
> > when dealing with different projects hosted on different servers.
> > 
> > Here is an attempt to change the format of pwclientrc so it is easier to
> > manage such scatered-around projects.
> 
> Oh awesome, I've always wanted to do this. My only concern is
> compatibility with older config files. How difficult would it be to
> automatically migrate?

We can either offer a migration plan, or continue supporting the old
format.

Needless to say, supporting the old format would make the code ugly.

As for the migration, there are three possibilities:
 1) migrate transparently on first call;
 2) error-out on old format, instructing to run with the --migrate
    option;
 3) error-out on old format, instruct to run another program to do the
    migration.

But the migration might not be that easy: some people (like me) may have
commented sections in their current .pwclientrc, so it is easier to
switch projects.

So, that's why I just decided to error-out on the old format, rather
than either migrate or support the legacy format.

Of course, the new .pwclientrc downloaded from the project's page should
be changed to include instructions on how to migrate, if needed.

The path of least surprise to the user is to support the old format, but
risks making the code a bit more complex...

What do you prefer?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'


More information about the Patchwork mailing list