Make Acked/Reviewd/Tested-by tags visible
thomas.petazzoni at free-electrons.com
Tue Nov 12 17:58:31 EST 2013
Dear Jeremy Kerr,
On Tue, 12 Nov 2013 08:37:26 +0800, Jeremy Kerr wrote:
> > We would like to suggest that the web GUI and the pwclient CLI both
> > display such tags besides each patch, a bit like (hypotetical output of
> > pwclient):
> > ID Tags State Subject
> > 123456 ART New Wonderfull patch to apply quickly
> I've been looking to implement this for a while, but didn't have any
> good ideas about how to present this in the UI. I love your proposal
> here with the flags, it's simple and I think would work well for the
> majority of cases.
> > Since patchwork already inserts those tags to the commit log (eg.
> > pwclient view PATCH-ID), I hope it would be easy enough to also display
> > it in the patch list.
> It's easy enough to pull these out of the comment at patch-display time,
> but a little more tricky with list views (without some horrible SQL
> joining). I'll work out a nice way to to this; I think it'll involve
> applying these flags when the follow-up comment is parsed.
> Other projects have different policies for their tagging (some require 3
> acks, for example), which will introduce a little complexity there too,
> but that's not insurmountable either.
Another thing that comes to mind is that not all Acked-by or Tested-by
are equal, I believe. An Acked-by from a well-known long-time
contributor will not be seen with the same level of trust that an
Acked-by from an unknown newcomer. Do we want to add a mechanism of
"rating"? But that would mean the project maintainer would have to
"rate" developers, which is not nice. Or maybe just a list of e-mails
that the project's maintainer considers as trustworthy, and only those
ones would be taken into account when displaying the ART flags?
Or maybe it doesn't matter too much, since in the vast majority of
cases, only well-known long-time contributors are doing reviews/acks.
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
More information about the Patchwork