Make Acked/Reviewd/Tested-by tags visible

Jeremy Kerr jk at
Tue Nov 12 11:37:26 EST 2013

Hi Yann,

> We would like to suggest that the web GUI and the pwclient CLI both
> display such tags besides each patch, a bit like (hypotetical output of
> pwclient):
>     ID     Tags State       Subject
>     123456 ART  New         Wonderfull patch to apply quickly

I've been looking to implement this for a while, but didn't have any
good ideas about how to present this in the UI. I love your proposal
here with the flags, it's simple and I think would work well for the
majority of cases.

> Since patchwork already inserts those tags to the commit log (eg.
> pwclient view PATCH-ID), I hope it would be easy enough to also display
> it in the patch list.

It's easy enough to pull these out of the comment at patch-display time,
but a little more tricky with list views (without some horrible SQL
joining). I'll work out a nice way to to this; I think it'll involve
applying these flags when the follow-up comment is parsed.

Other projects have different policies for their tagging (some require 3
acks, for example), which will introduce a little complexity there too,
but that's not insurmountable either.



More information about the Patchwork mailing list