New hook to update patch status on pull

Simo idra at samba.org
Tue Apr 2 22:54:31 EST 2013


On 04/02/2013 07:24 AM, Jeremy Kerr wrote:
> Hi Simo,
>
> Thanks for the contribution :)
>
>> In my setup I do not want to hook patchwork directly in the upstream
>> master tree as I do not have access to it.
>>
>> So I created this patch that will update the status of patches after a
>> pull.
>
> Not meaning to be critical here, but is there a reason you don't want 
> to use the existing scripts to do this, via the XMLRPC API?

The current scripts rely on the fact you can install hooks on the master 
tree everybody pushes to.
I cannot do that, I instead have a clone on the patchwork host and do 
cronjobed pulls. The post-merge hook is then used to analyse the pulled 
change-sets.

>> It adds some code in utils.py to performthe actual update and a
>> post-merge hook that is called when my cron job does a git pull from
>> master.
>
> I'd prefer that we don't add the main function to utils.py, but 
> instead create a new script for this.

Ok, I'll send a new patch with the function split out, any preference on 
the destination file name ?

Simo.


More information about the Patchwork mailing list