[PATCH] Get rid of hard-coded absolute paths.

Guilherme Salgado guilherme.salgado at linaro.org
Thu Mar 31 01:01:02 EST 2011

On Wed, 2011-03-30 at 14:11 +0800, Jeremy Kerr wrote:
> Hi Guilherme,
> > This is so that you don't have to change a dozen variables when you deploy
> > an instance somewhere other than on /srv/patchwork.
> [snip]
> > +# If you deploy somewhere other than /srv/patchwork you need to change the
> > +# settings below, preferably on local_settings.py instead of here.
> > +ROOT_DIR = '/srv/patchwork'
> This isn't overridable by local_settings; the dependent settings will be 
> generated before local_settings provides the new definition of ROOT_DIR.
> If you're happy with that behaviour (that the user needs to change the value 
> here, rather than in local_settings.py), then I'll remove this comment and 
> commit. Otherwise, we'll have to think up some way of allowing a later over-
> ride.

Yeah, I'm happy with that behavior, but I think what I meant with the
comment is that one would have to change all 3 settings below, although
it might make more sense to move ROOT_DIR above the comment as
overriding it in local_settings does not make sense unless you use it in
your TEMPLATE_DIRS/MEDIA_ROOT, in which case you'll have to do so.

If you'd like I can submit a second version of this patch.


Guilherme Salgado <https://launchpad.net/~salgado>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/patchwork/attachments/20110330/c895ebc0/attachment.pgp>

More information about the Patchwork mailing list