Using the From: address specified in the body

[Guilherme Salgado]

On Mon, 2011-03-21 at 11:07 +0800, Jeremy Kerr wrote:
> Hi Guilherme,
> 
> > I see that some emails with patches have a From: field in the body[1],
> 
> That's generated by git-format-patch, when the patch author is not the user 
> generating the patch files.
> 
> git-am will use these From: lines to correctly set the author when the patch 
> is applied to the maintainer's repo.
> 
> > and I'm wondering if there's any reason for not using that (when
> > available, of course) as the patch submitter.
> 
> Yes, this is intentional: "submitter" vs "author".
> 
> I've preferred to use the submitter of the patch, for a couple of reasons:
> 
>  * it makes correlating the patchwork patch list with a mail folder easier, as
>    a mail folder will show the mail sender
> 
>  * the 'submitter' is the person who is looking to have the patch added to
>    this project.

Right, that makes sense. Thanks for the clarification.

> 
> We could parse these From: lines (probably only when they appear as the first 
> line of the patch comment), but I haven't had any reason to do so, so far.
> 
> If we were to do this, I don't want to replace the submitter; it would be an 
> additional piece of metadata about the patch. We'd also need to work out how 
> this data appears in the patchwork UI; keep in mind that adding another 
> 'Person' column to the patch list will make scanning the list harder. I'd be 
> happy to add it to the single patch page, and it'd be good to use the author 
> when applying filters.

Yeah, storing it separately from the submitter seems to be the right
thing to do if we indeed start parsing that information.  I also agree
that adding another column to patch lists is not a good idea.

If we were to start collecting patch authorship, do we want to allow a
patch to have multiple authors?  I think I've seen patches (sent with
git send-mail) which had multiple From: lines in the body...

-- 
Guilherme Salgado <https://launchpad.net/~salgado>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/patchwork/attachments/20110321/208b4ab5/attachment.pgp>