Using the From: address specified in the body

Jeremy Kerr jk at
Mon Mar 21 14:07:37 EST 2011

Hi Guilherme,

> I see that some emails with patches have a From: field in the body[1],

That's generated by git-format-patch, when the patch author is not the user 
generating the patch files.

git-am will use these From: lines to correctly set the author when the patch 
is applied to the maintainer's repo.

> and I'm wondering if there's any reason for not using that (when
> available, of course) as the patch submitter.

Yes, this is intentional: "submitter" vs "author".

I've preferred to use the submitter of the patch, for a couple of reasons:

 * it makes correlating the patchwork patch list with a mail folder easier, as
   a mail folder will show the mail sender

 * the 'submitter' is the person who is looking to have the patch added to
   this project.

We could parse these From: lines (probably only when they appear as the first 
line of the patch comment), but I haven't had any reason to do so, so far.

If we were to do this, I don't want to replace the submitter; it would be an 
additional piece of metadata about the patch. We'd also need to work out how 
this data appears in the patchwork UI; keep in mind that adding another 
'Person' column to the patch list will make scanning the list harder. I'd be 
happy to add it to the single patch page, and it'd be good to use the author 
when applying filters.



More information about the Patchwork mailing list