[PATCH] Make sure the diffs of pull requests are stored in the Patch object.

[Guilherme Salgado]

On Fri, 2011-02-11 at 21:57 +0800, Jeremy Kerr wrote:
> Hi Guilherme,
> 
> > Aaargh, and to make things worse I don't see the original email with the
> > patch on the list's archive, even though my maillog tells me it was sent
> > to patchwork at lists.ozlabs.org. Is there any chance it got stuck in the
> > moderation queue?
> 
> It's not in the moderation queue, but I do see this in the mail log:
> 
>  Feb 11 22:16:34 bilbo postfix/smtpd[8361]: NOQUEUE: reject: RCPT from
>  adelie.canonical.com[91.189.90.139]: 550 5.1.8 <salgado at feioso>: Sender
>  address rejected: Domain not found; from=<salgado at feioso>
>  to=<patchwork at lists.ozlabs.org> proto=ESMTP helo=<adelie.canonical.com>
> 
> Bad From: address perhaps?

The copy that was CCed to me had my @linaro.org address as From:, but
indeed it was sent by my local (@feioso) postfix (although it uses a
relayhost). Anyway, I've changed my git config to use the relayhost
directly, which should avoid this.

I've also noticed that when I format-patch with a cover letter I end up
with two emails being sent (even though I'm sending just one patch),
which feels unnecessary to me (I'd think a single email with the patch
and a description would be enough), but maybe there's a reason for
having the description separate?  If not, is there a way to have git
send-email/format-patch send the description and the patch in a single
message?

Cheers,

-- 
Guilherme Salgado <https://launchpad.net/~salgado>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/patchwork/attachments/20110214/5a8bccb2/attachment.pgp>