Pull requests with patches
guilherme.salgado at linaro.org
Fri Feb 11 22:19:55 EST 2011
On Fri, 2011-02-11 at 11:37 +0800, Jeremy Kerr wrote:
> Hi Guilherme,
> > Oh, indeed. Haven't noticed that. I always use two additional levels.
> > However, I think, whitespace changes on lines that don't change
> > otherwise are best placed in separate commits -- easier to review.
> For changes like this, I'd prefer to keep it consistent with the existing
> formatting. We can revisit things later if it'd help though.
> Also, as Dirk has suggested, would you be able to send your patches with
> something like git-format-patch and git-send-email? Having a proper changelog
> entry helps me enormously, as does including test cases where appropriate
I've just done that, please let me know if it has everything you need.
> (don't worry about a testcase for this, but the pull request change could
> definitely use one).
Well, this is the pull request change, so the patch I just sent includes
a testcase. :)
Guilherme Salgado <https://launchpad.net/~salgado>
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 198 bytes
Desc: This is a digitally signed message part
More information about the Patchwork