Pull requests with patches

Jeremy Kerr jk at ozlabs.org
Fri Feb 11 14:37:32 EST 2011

Hi Guilherme,

> Oh, indeed. Haven't noticed that.  I always use two additional levels.
> However, I think, whitespace changes on lines that don't change
> otherwise are best placed in separate commits -- easier to review.

For changes like this, I'd prefer to keep it consistent with the existing 
formatting. We can revisit things later if it'd help though.

Also, as Dirk has suggested, would you be able to send your patches with 
something like git-format-patch and git-send-email? Having a proper changelog 
entry helps me enormously, as does including test cases where appropriate 
(don't worry about a testcase for this, but the pull request change could 
definitely use one).



More information about the Patchwork mailing list