[PATCH] Make it possible, via a config setting, to use OpenID for authentication

Guilherme Salgado guilherme.salgado at linaro.org
Tue Apr 19 22:36:20 EST 2011

On Tue, 2011-04-19 at 14:10 +0800, Jeremy Kerr wrote:
> Hi Guilherme,
> > This basically just adds instructions for people who may want to have their
> > patchwork instance as an OpenID relying party.  The only code changes are the
> > addition of the login_url() context processor, so that we always use the
> > LOGIN_URL defined in the settings,
> Looks good, just one thing:
> >  and the moving of the link to register from
> > the base template to the /accounts/login page.  The rationale for the latter
> > change is that the register link doesn't make sense on instances that use
> > OpenID, but I think that change is reasonable as registering on a given
> > instance is not something people will do often, so there's no reason to show a
> > link to that on every page, when the user is not logged in.
> I'd prefer to show the register link along with the login link always -
> it doesn't make sense to click on a 'login' link if you know you don't
> have an account (or don't know that you don't need one, in the case of
> OpenID).

Fair enough.

> For OpenID-enabled patchwork instances, the registration link should
> still be there, but could potentially direct to a login form, explaining
> the use of OpenID.

The only caveat is that if patchwork is configured to use a fixed OpenID
provider, there will be no login form as clicking the 'login' link will
take the user straight to the fixed OpenID provider, so I've created a
new page to take users to explain that to users and tell them to just
login. I'll submit a second version of this patch shortly.


Guilherme Salgado <https://launchpad.net/~salgado>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/patchwork/attachments/20110419/702ce0c9/attachment.pgp>

More information about the Patchwork mailing list