[PATCH] Make it possible, via a config setting, to use OpenID for authentication

Jeremy Kerr jk at ozlabs.org
Tue Apr 19 16:10:27 EST 2011


Hi Guilherme,

> This basically just adds instructions for people who may want to have their
> patchwork instance as an OpenID relying party.  The only code changes are the
> addition of the login_url() context processor, so that we always use the
> LOGIN_URL defined in the settings,

Looks good, just one thing:

>  and the moving of the link to register from
> the base template to the /accounts/login page.  The rationale for the latter
> change is that the register link doesn't make sense on instances that use
> OpenID, but I think that change is reasonable as registering on a given
> instance is not something people will do often, so there's no reason to show a
> link to that on every page, when the user is not logged in.

I'd prefer to show the register link along with the login link always -
it doesn't make sense to click on a 'login' link if you know you don't
have an account (or don't know that you don't need one, in the case of
OpenID).

For OpenID-enabled patchwork instances, the registration link should
still be there, but could potentially direct to a login form, explaining
the use of OpenID.

Cheers,


Jeremy



More information about the Patchwork mailing list