Annotating superseded/accepted patches

Jeremy Kerr jk at ozlabs.org
Wed Sep 30 17:43:55 EST 2009


Carl-Daniel,

> is there some way to store by which patch an existing patch was
> superseded, preferably with a link to the newer instance? The web
> interface only lets me change the state to "Superseded", but there is no
> text field (or dropdown box) where I could enter a patch number or patch
> name.

The grand-plan for this is a 'patch relations' table, containing (patch_from, 
relation, patch_to) tuples. This way, we can store all sorts of stuff:

 * patches that are in the same series
 * patches that supersede other patches
 * patches that are follow-ups to other patches

This is a bit of a longer-term project, as it'll require a bit of work to get 
right, mostly on the parsing-side of things (ie, figuring out when a patch is 
in a series is non-trivial).

> By the way, is there any official policy for or against making the
> commit ID clickable?

No policy, I'd suggest something like a 'rcs_url' in the Project object, which 
we do a template replacement on, containing something like:

 "http://git.ozlabs.org/?p=patchwork;a=commitdiff;h=%s".

If you forsee having to use other parameters in the template replacement, we 
could use the python dict-style template parameters:

 "http://git.ozlabs.org/?p=patchwork;a=commitdiff;h=%(commit_id)s".

but the downside here is that the database contents will become python-
centric.

If you're keen to do this, go ahead. Otherwise, I'll add to TODO.

Cheers,


Jeremy


More information about the Patchwork mailing list