[OpenPower-Firmware] [PATCH 1/2] tty/hvc: Use IRQF_SHARED for OPAL hvc consoles

[Samuel Mendoza-Jonas]

On Wed, 2016-07-13 at 11:36 -0300, Murilo Opsfelder Araújo wrote:
> On 07/12/2016 10:15 PM, Samuel Mendoza-Jonas wrote:
> [...]
> > 
> > diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
> > index 47b54c6..b7cd0ae 100644
> > --- a/drivers/tty/hvc/hvc_opal.c
> > +++ b/drivers/tty/hvc/hvc_opal.c
> > @@ -224,6 +224,9 @@ static int hvc_opal_probe(struct platform_device *dev)
> >  	hp = hvc_alloc(termno, irq, ops, MAX_VIO_PUT_CHARS);
> >  	if (IS_ERR(hp))
> >  		return PTR_ERR(hp);
> > +
> > +	/* hvc consoles on powernv may need to share a single irq */
> > +	hp->flags = IRQF_SHARED;
> 
> There is no other flag being used at the moment but shouldn't we do
> hp->flags |= IRQF_SHARED instead?
> 

Good point - hvc_alloc() doesn't set any default flags so at the moment
it's up to each type of hvc init to set the flags themselves. If that
were to change in the future it would be something to check.