[OpenPower-Firmware] [PATCH 1/2] tty/hvc: Use IRQF_SHARED for OPAL hvc consoles

Murilo Opsfelder Araújo muriloo at linux.vnet.ibm.com
Thu Jul 14 00:36:39 AEST 2016


On 07/12/2016 10:15 PM, Samuel Mendoza-Jonas wrote:
[...]
> diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
> index 47b54c6..b7cd0ae 100644
> --- a/drivers/tty/hvc/hvc_opal.c
> +++ b/drivers/tty/hvc/hvc_opal.c
> @@ -224,6 +224,9 @@ static int hvc_opal_probe(struct platform_device *dev)
>  	hp = hvc_alloc(termno, irq, ops, MAX_VIO_PUT_CHARS);
>  	if (IS_ERR(hp))
>  		return PTR_ERR(hp);
> +
> +	/* hvc consoles on powernv may need to share a single irq */
> +	hp->flags = IRQF_SHARED;

There is no other flag being used at the moment but shouldn't we do
hp->flags |= IRQF_SHARED instead?

-- 
Murilo



More information about the OpenPower-Firmware mailing list