[PATCH] dt-bindings: hwmon: Add adt7462
Krzysztof Kozlowski
krzk at kernel.org
Thu Sep 19 20:39:03 AEST 2024
On 19/09/2024 11:43, Chanh Nguyen wrote:
>>> +properties:
>>> + compatible:
>>> + const: onnn,adt7462
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + resets:
>>> + maxItems: 1
>>
>> How would this work? 'resets' generally is used for on-chip devices and
>> a reset controller. That doesn't exist at the board level. A standalone
>> device typically uses a GPIO lines if there's a s/w controlled reset.
>> That would be the 'reset-gpios' property.
>>
>
> Thank Rob for your comments! The ADT7462 includes an active low reset
> pin (Pin #14).
>
> I'll change 'resets' into the 'reset-gpios' property.
>
> The example in the binding will be
The question how did it work in the first place is still valid... I
think we might benefit from asking people to post their upstreamed DTS.
Otherwise we will take broken or half-baked bindings, because we never
saw the bigger picture. :(
Best regards,
Krzysztof
More information about the openbmc
mailing list