[PATCH linux dev-4.7 1/1] First commit driver

Andrew Jeffery andrew at codeconstruct.com.au
Mon Jul 29 11:13:49 AEST 2024


Hello Wenliang,

On Fri, 2024-07-26 at 04:01 -0400, Wenliang wrote:
> ---
>  Desktop/Linux-4.9.88/drivers/hwmon/SQ52205.c | 563 +++++++++++++++++++
>  1 file changed, 563 insertions(+)

Thanks for the patch. However, a few points:

- I'm not sure how you've organised your work, but the Linux git tree
doesn't contain paths like `Desktop/Linux-4.9.88`. You will need to
follow the regular process for kernel development (clone linux.git from
git.kernel.org[1] for instance).

[1]:
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/

- OpenBMC's fork of Linux exists to minimise the time we spend
maintaining the kernel, while maximising the ability to integrate BMC-
related work from upstream as soon as we can. We've roughly settled on
running LTS releases and following the stable tags, while backporting
drivers and SoC support where necessary. This means you should send
your work upstream _first_. Once it's merged there we can backport it
to the OpenBMC kernel tree.

- The dev-4.7 branch is obsolete. If this patch were to be applied, it
would be applied to the dev-6.6 branch, as this is the current LTS.
Please make sure to test against upstream _and_ the dev-6.6 branch if
you would like to see the work integrated there.

- When sending your work upstream you should adhere to the guidelines
provided in the documentation. Particularly, "First commit driver" as a
patch subject needs some improvement. What subsystem (hwmon)? What
device (SQ52205)? It would be worth spending some time reviewing the
following resources:

A guide to the Kernel Development Process:
  https://docs.kernel.org/process/development-process.html

Submitting patches: the essential guide to getting your code into the
kernel
  https://docs.kernel.org/process/submitting-patches.html

All the best,

Andrew


More information about the openbmc mailing list