[linux dev-6.6 v1] spi: npcm-fiu: add dual and quad write support
Tomer Maimon
tmaimon77 at gmail.com
Wed Jul 10 04:48:13 AEST 2024
Add dual and quad write support by writing the command write in the UMA
register first and then write the data in chunks of 16 bytes.
Signed-off-by: Stanley Chu <yschu at nuvoton.com>
Signed-off-by: Tomer Maimon <tmaimon77 at gmail.com>
---
drivers/spi/spi-npcm-fiu.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/spi/spi-npcm-fiu.c b/drivers/spi/spi-npcm-fiu.c
index e42248519688..a999614340d6 100644
--- a/drivers/spi/spi-npcm-fiu.c
+++ b/drivers/spi/spi-npcm-fiu.c
@@ -392,7 +392,7 @@ static int npcm_fiu_uma_write(struct spi_mem *mem,
{
struct npcm_fiu_spi *fiu =
spi_controller_get_devdata(mem->spi->controller);
- u32 uma_cfg = BIT(10);
+ u32 uma_cfg = cmd ? BIT(10) : 0;
u32 data_reg[4] = {0};
u32 val;
u32 i;
@@ -402,8 +402,11 @@ static int npcm_fiu_uma_write(struct spi_mem *mem,
(spi_get_chipselect(mem->spi, 0) <<
NPCM_FIU_UMA_CTS_DEV_NUM_SHIFT));
- regmap_update_bits(fiu->regmap, NPCM_FIU_UMA_CMD,
- NPCM_FIU_UMA_CMD_CMD, cmd);
+ if (cmd)
+ regmap_update_bits(fiu->regmap, NPCM_FIU_UMA_CMD,
+ NPCM_FIU_UMA_CMD_CMD, cmd);
+ else
+ uma_cfg |= ilog2(op->data.buswidth) << NPCM_FIU_UMA_CFG_WDBPCK_SHIFT;
if (data_size) {
memcpy(data_reg, data, data_size);
@@ -463,8 +466,7 @@ static int npcm_fiu_manualwrite(struct spi_mem *mem,
/* Starting the data writing loop in multiples of 8 */
for (idx = 0; idx < num_data_chunks; ++idx) {
- ret = npcm_fiu_uma_write(mem, op, data[0], false,
- &data[1], CHUNK_SIZE - 1);
+ ret = npcm_fiu_uma_write(mem, op, 0, false, &data[0], CHUNK_SIZE);
if (ret)
return ret;
@@ -473,8 +475,7 @@ static int npcm_fiu_manualwrite(struct spi_mem *mem,
/* Handling chunk remains */
if (remain_data > 0) {
- ret = npcm_fiu_uma_write(mem, op, data[0], false,
- &data[1], remain_data - 1);
+ ret = npcm_fiu_uma_write(mem, op, 0, false, &data[0], remain_data);
if (ret)
return ret;
}
--
2.34.1
More information about the openbmc
mailing list