[linux dev-6.6 v1 4/6] arm64: dts: modify clock property in modules node

[Tomer Maimon]

Hi Andrew,

One more question, for this change the clock node should be removed.

I am afraid that removing the clock node could cause an ABI break, not?

Thanks,

Tomer

On Wed, 3 Jul 2024 at 11:13, Tomer Maimon <tmaimon77 at gmail.com> wrote:
>
> Hi Andrew,
>
> Great suggestion :-) i will try it!
>
> Thanks,
>
> Tomer
>
> On Wed, 3 Jul 2024 at 09:30, Andrew Jeffery <andrew at codeconstruct.com.au> wrote:
> >
> > On Wed, 2024-07-03 at 15:55 +0930, Andrew Jeffery wrote:
> > > On Mon, 2024-07-01 at 10:10 +0300, Tomer Maimon wrote:
> > > > Modify clock property handler in UART, CPU, PECI modules to reset
> > > > controller.
> > >
> > > Sooo... I'm not sure how much of a hack this is, as it's not clear to
> > > me that the devicetree spec allows multiple labels on a node, but `dtc`
> > > seems to accept it.
> > >
> > > You can reduce this patch to a short diff with:
> > >
> > > -               rstc: reset-controller at f0801000 {
> > > +               clk: rstc: reset-controller at f0801000 {
> > >
> > > and leave the rest of the phandles in-tact.
> > >
> >
> > Well, there is some precedent:
> >
> > ```
> > $ git grep -E '.+: .+: .+ \{' -- arch/arm/boot/dts/
> > arch/arm/boot/dts/arm/arm-realview-eb.dtsi:             charlcd: fpga_charlcd: charlcd at 10008000 {
> > arch/arm/boot/dts/arm/vexpress-v2p-ca9.dts:             smbclk: oscclk2: tcrefclk {
> > arch/arm/boot/dts/rockchip/rk3188-bqedison2qc.dts:                      vcc_io: vcc_hdmi: REG4 {
> > arch/arm/boot/dts/rockchip/rk3288-firefly-reload-core.dtsi:                     vccio_wl: vcc_18: REG11 {
> > arch/arm/boot/dts/rockchip/rk3288-firefly-reload.dts:   vcc_5v: vcc_sys: vsys-regulator {
> > arch/arm/boot/dts/rockchip/rk3288-firefly.dtsi: vbat_wl: vcc_sys: vsys-regulator {
> > arch/arm/boot/dts/rockchip/rk3288-firefly.dtsi:                 vccio_wl: vcc_18: REG11 {
> > arch/arm/boot/dts/rockchip/rk3288-rock2-som.dtsi:                       vcc_io: vccio_codec: REG2 {
> > arch/arm/boot/dts/rockchip/rk3288-veyron.dtsi:                  vcc18_wl: vcc18_flashio: vcc_18: DCDC_REG4 {
> > arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts:                     vqmmc_sdcard: ldo4_reg: LDO4 {
> > arch/arm/boot/dts/samsung/exynos5800-peach-pi.dts:                      vqmmc_sdcard: ldo4_reg: LDO4 {
> > ```
> >
> > Andrew