[PATCH u-boot v2019.04-aspeed-openbmc] ARM: dts: aspeed: add Delta AHE-50DC BMC

[Zev Weiss]

On Tue, May 10, 2022 at 11:04:01PM PDT, Joel Stanley wrote:
>On Wed, 11 May 2022 at 03:37, Zev Weiss <zev at bewilderbeest.net> wrote:
>>
>> On Thu, Apr 14, 2022 at 02:00:45PM PDT, Zev Weiss wrote:
>> > The Delta AHE-50DC Open19 power shelf uses a pair of AST1250 BMCs that
>> > are mostly compatible with the existing ast2400-evb device tree, with
>> > a couple small tweaks for the serial console UART and ethernet MACs.
>> >
>> > Signed-off-by: Zev Weiss <zev at bewilderbeest.net>
>> > ---
>> >  arch/arm/dts/Makefile             |  1 +
>> >  arch/arm/dts/ast2400-ahe-50dc.dts | 34 +++++++++++++++++++++++++++++++
>> >  2 files changed, 35 insertions(+)
>> >  create mode 100644 arch/arm/dts/ast2400-ahe-50dc.dts
>> >
>>
>> Ping...does this look like a reasonable approach for a board that's
>> mostly-but-not-entirely EVB-compatible?
>
>That looks okay. Are you sure you have everything that the evb enables
>on your board? Dual flashes on both flash controllers, etc?
>

Ah, good point -- while it does have dual flashes on the fmc, I should
probably disable spi1.

>I wonder if it would be better to put more into ast2400-u-boot.dtsi
>and use that?
>
>But I don't have strong opinions either way. Your device tree looks
>fine, and I am happy to merge it.
>

Hmm, hadn't considered that possibility...I'm likewise not strongly
opinionated, but I guess the current approach of extending the evb dts
seems slightly simpler?

Thanks for the review -- I'll send a v2 with spi1 disabled soon.


Zev