[PATCH u-boot v2019.04-aspeed-openbmc] ARM: dts: aspeed: add Delta AHE-50DC BMC

[Joel Stanley]

On Wed, 11 May 2022 at 03:37, Zev Weiss <zev at bewilderbeest.net> wrote:
>
> On Thu, Apr 14, 2022 at 02:00:45PM PDT, Zev Weiss wrote:
> > The Delta AHE-50DC Open19 power shelf uses a pair of AST1250 BMCs that
> > are mostly compatible with the existing ast2400-evb device tree, with
> > a couple small tweaks for the serial console UART and ethernet MACs.
> >
> > Signed-off-by: Zev Weiss <zev at bewilderbeest.net>
> > ---
> >  arch/arm/dts/Makefile             |  1 +
> >  arch/arm/dts/ast2400-ahe-50dc.dts | 34 +++++++++++++++++++++++++++++++
> >  2 files changed, 35 insertions(+)
> >  create mode 100644 arch/arm/dts/ast2400-ahe-50dc.dts
> >
>
> Ping...does this look like a reasonable approach for a board that's
> mostly-but-not-entirely EVB-compatible?

That looks okay. Are you sure you have everything that the evb enables
on your board? Dual flashes on both flash controllers, etc?

I wonder if it would be better to put more into ast2400-u-boot.dtsi
and use that?

But I don't have strong opinions either way. Your device tree looks
fine, and I am happy to merge it.

> Once the regulator/extcon
> driver question gets sorted out I'll post a kernel dts, after which I
> think the necessary pieces will be in place to add an OpenBMC meta-layer
> for this system.
>
> This patch is also still outstanding as a semi-dependency (not strictly
> necessary for this, but nice to have for it):
> https://lore.kernel.org/openbmc/20220414205950.26406-1-zev@bewilderbeest.net/
>
>
> Thanks,
> Zev
>