[u-boot,v2019.04-aspeed-openbmc v3 1/1] arm: dts: Aspeed: add Bletchley dts

[Joel Stanley]

On Mon, 21 Feb 2022 at 11:02, Potin Lai (賴柏廷) <Potin.Lai at quantatw.com> wrote:
>
> On 2/11/22 08:54, Potin Lai (賴柏廷) wrote:
> > Initial introduction of Bletchley equipped with
> > Aspeed 2600 BMC SoC.
> >
> > Signed-off-by: Potin Lai <potin.lai at quantatw.com>
> >
> > ---
> >
> > change v2 -> v3:
> > * update model & compatible to match with kernel dts
> >
> > change v1 -> v2:
> > * sort Makefile alphabetically
> > * add licence and copyright
> > * update model name
> > * remove the nodes not using (fsi, emmc, sdhci, ehci, pcie & display_port)
>
> Hi Joel, could you help review this patch and let me know if any modification needed? Many thanks

It looks good. I've applied it to the openbmc u-boot tree.

In the future, please try to get some reviews from your colleagues.

Cheers,

Joel


>
> Potin
>
> > ---
> >  arch/arm/dts/Makefile              |   9 +-
> >  arch/arm/dts/ast2600-bletchley.dts | 223 +++++++++++++++++++++++++++++
> >  2 files changed, 228 insertions(+), 4 deletions(-)
> >  create mode 100644 arch/arm/dts/ast2600-bletchley.dts
> >
> > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> > index df844065cd..ac93a89c07 100755
> > --- a/arch/arm/dts/Makefile
> > +++ b/arch/arm/dts/Makefile
> > @@ -677,15 +677,16 @@ dtb-$(CONFIG_ARCH_BCM6858) += \
> >  dtb-$(CONFIG_ARCH_ASPEED) += \
> >       ast2400-evb.dtb \
> >       ast2500-evb.dtb \
> > -     ast2600-evb.dtb \
> > -     ast2600-ncsi.dtb \
> >       ast2600a0-evb.dtb \
> >       ast2600a1-evb.dtb \
> > +     ast2600-bletchley.dtb \
> > +     ast2600-evb.dtb \
> >       ast2600-fpga.dtb \
> > +     ast2600-intel.dtb \
> > +     ast2600-ncsi.dtb \
> >       ast2600-rainier.dtb \
> >       ast2600-slt.dtb \
> > -     ast2600-tacoma.dtb \
> > -     ast2600-intel.dtb
> > +     ast2600-tacoma.dtb
> >
> >  dtb-$(CONFIG_ARCH_STI) += stih410-b2260.dtb
> >
> > diff --git a/arch/arm/dts/ast2600-bletchley.dts b/arch/arm/dts/ast2600-bletchley.dts
> > new file mode 100644
> > index 0000000000..57ca845b94
> > --- /dev/null
> > +++ b/arch/arm/dts/ast2600-bletchley.dts
> > @@ -0,0 +1,223 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +// Copyright (c) 2022 Meta Platforms Inc.
> > +/dts-v1/;
> > +
> > +#include "ast2600-u-boot.dtsi"
> > +
> > +/ {
> > +     model = "Facebook Bletchley BMC";
> > +     compatible = "facebook,bletchley-bmc", "aspeed,ast2600";
> > +
> > +     memory {
> > +             device_type = "memory";
> > +             reg = <0x80000000 0x40000000>;
> > +     };
> > +
> > +     chosen {
> > +             stdout-path = &uart5;
> > +     };
> > +
> > +     aliases {
> > +             mmc0 = &emmc_slot0;
> > +             mmc1 = &sdhci_slot0;
> > +             mmc2 = &sdhci_slot1;
> > +             spi0 = &fmc;
> > +             spi1 = &spi1;
> > +             spi2 = &spi2;
> > +             ethernet0 = &mac0;
> > +             ethernet1 = &mac1;
> > +             ethernet2 = &mac2;
> > +             ethernet3 = &mac3;
> > +     };
> > +
> > +     cpus {
> > +             cpu at 0 {
> > +                     clock-frequency = <800000000>;
> > +             };
> > +             cpu at 1 {
> > +                     clock-frequency = <800000000>;
> > +             };
> > +     };
> > +};
> > +
> > +&uart5 {
> > +     u-boot,dm-pre-reloc;
> > +     status = "okay";
> > +};
> > +
> > +&sdrammc {
> > +     clock-frequency = <400000000>;
> > +};
> > +
> > +&wdt1 {
> > +     status = "okay";
> > +};
> > +
> > +&wdt2 {
> > +     status = "okay";
> > +};
> > +
> > +&wdt3 {
> > +     status = "okay";
> > +};
> > +
> > +&mdio {
> > +     status = "okay";
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_mdio4_default>;
> > +     #address-cells = <1>;
> > +     #size-cells = <0>;
> > +};
> > +
> > +&mac2 {
> > +     status = "okay";
> > +     phy-mode = "rgmii";
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_rgmii3_default &pinctrl_mac3link_default>;
> > +     fixed-link {
> > +             speed = <1000>;
> > +             full-duplex;
> > +     };
> > +};
> > +
> > +&fmc {
> > +     status = "okay";
> > +
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_fmcquad_default>;
> > +
> > +     flash at 0 {
> > +             compatible = "spi-flash", "sst,w25q256";
> > +             status = "okay";
> > +             spi-max-frequency = <50000000>;
> > +             spi-tx-bus-width = <2>;
> > +             spi-rx-bus-width = <2>;
> > +     };
> > +
> > +     flash at 1 {
> > +             compatible = "spi-flash", "sst,w25q256";
> > +             status = "okay";
> > +             spi-max-frequency = <50000000>;
> > +             spi-tx-bus-width = <2>;
> > +             spi-rx-bus-width = <2>;
> > +     };
> > +
> > +     flash at 2 {
> > +             compatible = "spi-flash", "sst,w25q256";
> > +             status = "okay";
> > +             spi-max-frequency = <50000000>;
> > +             spi-tx-bus-width = <2>;
> > +             spi-rx-bus-width = <2>;
> > +     };
> > +};
> > +
> > +&spi1 {
> > +     status = "okay";
> > +
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_spi1_default &pinctrl_spi1abr_default
> > +                     &pinctrl_spi1cs1_default &pinctrl_spi1wp_default
> > +                     &pinctrl_spi1wp_default &pinctrl_spi1quad_default>;
> > +
> > +     flash at 0 {
> > +             compatible = "spi-flash", "sst,w25q256";
> > +             status = "okay";
> > +             spi-max-frequency = <50000000>;
> > +             spi-tx-bus-width = <4>;
> > +             spi-rx-bus-width = <4>;
> > +     };
> > +
> > +     flash at 1 {
> > +             compatible = "spi-flash", "sst,w25q256";
> > +             status = "okay";
> > +             spi-max-frequency = <50000000>;
> > +             spi-tx-bus-width = <4>;
> > +             spi-rx-bus-width = <4>;
> > +     };
> > +};
> > +
> > +&spi2 {
> > +     status = "okay";
> > +
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_spi2_default &pinctrl_spi2cs1_default
> > +                     &pinctrl_spi2cs2_default &pinctrl_spi2quad_default>;
> > +
> > +     flash at 0 {
> > +             compatible = "spi-flash", "sst,w25q256";
> > +             status = "okay";
> > +             spi-max-frequency = <50000000>;
> > +             spi-tx-bus-width = <4>;
> > +             spi-rx-bus-width = <4>;
> > +     };
> > +
> > +     flash at 1 {
> > +             compatible = "spi-flash", "sst,w25q256";
> > +             status = "okay";
> > +             spi-max-frequency = <50000000>;
> > +             spi-tx-bus-width = <4>;
> > +             spi-rx-bus-width = <4>;
> > +     };
> > +
> > +     flash at 2 {
> > +             compatible = "spi-flash", "sst,w25q256";
> > +             status = "okay";
> > +             spi-max-frequency = <50000000>;
> > +             spi-tx-bus-width = <4>;
> > +             spi-rx-bus-width = <4>;
> > +     };
> > +};
> > +
> > +&i2c4 {
> > +     status = "okay";
> > +
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_i2c5_default>;
> > +};
> > +
> > +&i2c5 {
> > +     status = "okay";
> > +
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_i2c6_default>;
> > +};
> > +
> > +&i2c6 {
> > +     status = "okay";
> > +
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_i2c7_default>;
> > +};
> > +
> > +&i2c7 {
> > +     status = "okay";
> > +
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_i2c8_default>;
> > +};
> > +
> > +&i2c8 {
> > +     status = "okay";
> > +
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_i2c9_default>;
> > +};
> > +
> > +&scu {
> > +     mac0-clk-delay = <0x10 0x0a
> > +                       0x10 0x10
> > +                       0x10 0x10>;
> > +     mac1-clk-delay = <0x10 0x0a
> > +                       0x10 0x10
> > +                       0x10 0x10>;
> > +     mac2-clk-delay = <0x08 0x04
> > +                       0x08 0x04
> > +                       0x08 0x04>;
> > +     mac3-clk-delay = <0x08 0x04
> > +                       0x08 0x04
> > +                       0x08 0x04>;
> > +};
> > +
> > +&hace {
> > +     status = "okay";
> > +};
>
>