[PATCH U-Boot v2019.04-aspeed-openbmc 6/6] ast2600: Add GPIO controller and hog TPM reset pin

Andrew Jeffery andrew at aj.id.au
Fri Feb 4 09:12:00 AEDT 2022



On Fri, 4 Feb 2022, at 02:31, Eddie James wrote:
> On 2/2/22 20:17, Andrew Jeffery wrote:
>>
>> On Tue, 25 Jan 2022, at 05:45, Eddie James wrote:
>>> Hog the GPIO pin to reset the TPM.
>>>
>>> Signed-off-by: Eddie James <eajames at linux.ibm.com>
>>> ---
>>>   arch/arm/dts/ast2600-rainier.dts | 11 +++++++++++
>>>   1 file changed, 11 insertions(+)
>>>
>>> diff --git a/arch/arm/dts/ast2600-rainier.dts b/arch/arm/dts/ast2600-rainier.dts
>>> index aae507b4c2..d0e82d1512 100755
>>> --- a/arch/arm/dts/ast2600-rainier.dts
>>> +++ b/arch/arm/dts/ast2600-rainier.dts
>>> @@ -108,3 +108,14 @@
>>>   	u-boot,dm-pre-reloc;
>>>   	status = "okay";
>>>   };
>>> +
>>> +&gpio0 {
>>> +	u-boot,dm-pre-reloc;
>>> +
>>> +	tpm_reset {
>>> +		u-boot,dm-pre-reloc;
>> Do we need this in the hog node? Seems like it's only necessary in controller nodes.
>
>
> Yes it is necessary, the SPL dtc compiler will cull anything without 
> that property.

Are you sure it's done at dts translation time?

My understanding is the driver model core will only instantiate drivers 
for devices with the property. This suggests all nodes are retained.

I used uclass_get_device_by_driver() in the mach-aspeed patch which 
will forcibly probe the driver.

Andrew


More information about the openbmc mailing list