[PATCH 1/2] pinctrl: aspeed: Enable pass-through on GPIOE1 and GPIOE3 free

[Zev Weiss]

On Wed, Feb 02, 2022 at 02:49:13PM PST, Andrew Jeffery wrote:
>
>
>On Thu, 3 Feb 2022, at 06:29, Bills, Jason M wrote:
>> This change adds a gpio_disable_free() implementation that checks
>> if the GPIO being freed is GPIOE1 (33) or GPIOE3 (35) and will
>> re-enable the pass-through mux.
>
>Okay. So trying to pull back from the implementation for a moment:
>
>Perhaps we can view pass-through as a property on a pair of GPIOs, rather than a mux state? I think it would be better if we could, for instance, annotate this in the devicetree?
>
>If we did that I don't think we're require this awkward and pin-specific implementation of the free callback for GPIOs.
>

Agreed, a way to specify this in DT would be nice -- e3c246d4i, for
example, also wants GPIO passthrough, but on GPIOD rather than GPIOE.
Hopefully whatever mechanism we arrive at for this could support either.

I don't have much expertise in the pinctrl subsystem to offer for code
review, but I'm happy to help with testing for this.


Zev