[PATCH u-boot v2019.04-aspeed-openbmc 1/2] aspeed/sdram: Use device tree to configure ECC

[Andrew Jeffery]

On Wed, 17 Aug 2022, at 12:34, Dhananjay Phadke wrote:
> On 8/16/2022 6:59 PM, Joel Stanley wrote:
>> Instead of configuring ECC based on the build config, use a device tree
>> property to selectively enable ECC at runtime.
>> 
>> There are two properties:
>> 
>>    aspeed,ecc-enabled;
>>    aspeed,ecc-size = "512";
>> 
>> The enabled property is a boolean that enables ECC if it is present.
>> 
>> The size is the number of MB that should be covered by ECC. Setting it
>> to zero, or omitting it, defaults the ECC size to "auto detect".
>
> What's the use case for enabling ECC only on part of the DRAM or not
> using max possible DRAM space?
>

I have some hand-wavy concerns about the impact of ECC on the 
configuration of the AHB bridges, but that needs to be investigated 
with some experiments.

As Joel said, some feedback from Aspeed on the use-cases would be handy.

Andrew