[External] Re: EEPROM Validation issue in Fru Device.

Lei Yu yulei.sh at bytedance.com
Thu Sep 30 11:50:18 AEST 2021


On Wed, Sep 29, 2021 at 7:59 PM Patrick Williams <patrick at stwcx.xyz> wrote:
>
> On Wed, Sep 29, 2021 at 05:53:33AM +0000, Kumar Thangavel wrote:
> >
> > 1.       How the function isDevice16Bit Validated for 16 bit device ?
>
> My understanding is that Vijay wrote this originally when he wrote the Tiogapass
> port.  You should be able to confirm if it works there.
>
> >
> > 2.       Is my validation and analysis is correct ?
>
> Other people have complained (on Discord) that this current code doesn't work
> for all eeproms.  If you have something that works better and doesn't break
> Tiogapass support, I would expect it to be accepted as a change in fru-device.

We do hit the issue on this. The FRU in our system is 16-bit and
stored with an offset.
We have internal patches to handle the 16-bit and offset issue, but
the change is tricky and not generic for upstream.
It would be very appreciated to get a generic solution to handle such issues.

-- 
BRs,
Lei YU


More information about the openbmc mailing list