EEPROM Validation issue in Fru Device.

[Kumar Thangavel]

Classification: Confidential

Thanks Patrick for your responses.

Please find my response inline below.

Thanks,
Kumar.

-----Original Message-----
From: Patrick Williams <patrick at stwcx.xyz>
Sent: Wednesday, September 29, 2021 5:19 PM
To: Kumar Thangavel <thangavel.k at hcl.com>
Cc: openbmc at lists.ozlabs.org; Velumani T-ERS,HCLTech <velumanit at hcl.com>; Amithash Prasad <amithash at fb.com>; Sai Dasari <sdasari at fb.com>; Ed Tanous <ed at tanous.net>; Vernon Mauery <vernon.mauery at linux.intel.com>; Jae Hyun Yoo <jae.hyun.yoo at linux.intel.com>
Subject: Re: EEPROM Validation issue in Fru Device.

On Wed, Sep 29, 2021 at 05:53:33AM +0000, Kumar Thangavel wrote:
>
> 1.       How the function isDevice16Bit Validated for 16 bit device ?

My understanding is that Vijay wrote this originally when he wrote the Tiogapass port.  You should be able to confirm if it works there.

Sure. I will confirm with Tiogapass.

>
> 2.       Is my validation and analysis is correct ?

Other people have complained (on Discord) that this current code doesn't work for all eeproms.  If you have something that works better and doesn't break Tiogapass support, I would expect it to be accepted as a change in fru-device.

OK. Will update the fru-device to make it work for all the platforms.

--
Patrick Williams
::DISCLAIMER::
________________________________
The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.
________________________________