[phosphor-logging] About the "Stop emitting Entry propChanged before ifacesAdded" change reason

[CS20 CHMa0]

Hi Matt and Patrick,
Thanks for your apply, it seems very reasonable.
I think the bmcweb code need some update to avoid using wrong behavior.

-----Original Message-----
From: Patrick Williams [mailto:patrick at stwcx.xyz]
Sent: Thursday, October 21, 2021 1:18 AM
To: Matt Spinler <mspinler at linux.ibm.com>
Cc: CS20 CHMa0 <CHMA0 at nuvoton.com>; openbmc at lists.ozlabs.org
Subject: Re: [phosphor-logging] About the "Stop emitting Entry propChanged before ifacesAdded" change reason

On Wed, Oct 20, 2021 at 10:13:06AM -0500, Matt Spinler wrote:
> values, and then explicitly emits the IA signal.   Others can chime
> in, but I didn't see it as proper D-Bus behavior to emit
> propertiesChanged before InterfacesAdded, since in fact no property is
> changing after the interface was added.

Correct.  PropertiesChanged signals should not show up before InterfacesAdded.

> It seems like every application does their own thing here, so maybe we
> can come up with some official best practices for how to emit signals
> for new interfaces (unless it's there and I missed it).

I'll admit the sdbusplus API is not great for this and a lot of applications do it wrong.  There was this issue on the backlog to come up with something
"better": https://github.com/openbmc/sdbusplus/issues/53

--
Patrick Williams
________________________________
________________________________
 The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.