[phosphor-logging] About the "Stop emitting Entry propChanged before ifacesAdded" change reason

CS20 CHMa0 CHMA0 at nuvoton.com
Wed Oct 20 19:39:47 AEDT 2021


Hi Matt,
I meet an issue in bmcweb while update service handle firmware update error
https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/update_service.hpp#L321

After I  revert the change or try to change the match rule from 'PropertiesChanged' to 'InterfacesAdded',
the error handler work well in update service.
     fwUpdateErrorMatcher = std::make_unique<sdbusplus::bus::match::match>(
         *crow::connections::systemBus,
-        "type='signal',member='PropertiesChanged',path_namespace='/xyz/"
-        "openbmc_project/logging/entry',"
-        "arg0='xyz.openbmc_project.Logging.Entry'",
+        "interface='org.freedesktop.DBus.ObjectManager',type='signal',"
+        "member='InterfacesAdded',"
+        "path='/xyz/openbmc_project/logging'",

May I ask the reason why you update the change?  https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-logging/+/46055


Thanks
Brian
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20211020/cf487565/attachment.htm>


More information about the openbmc mailing list